Coding thoughts - when I get a pull request with too many code changes! π π©π€¦πΎββοΈβ
β£My thoughts when I get a pull request with too many code changes π π©π€¦πΎββοΈ
When it has too many lines of code changed, a lack of description/context, or lack of single/clear focus, it might lead to a swift βLGTM (looks good to me)β and MERGED π .
As developers, we are often under time constraints and a load of work. Reviewing large/bad pull requests can be overwhelming at times.
This leads to sometimes devs not doing a deep enough review and bugs getting though; I know Iβve done it and if you work long enough you will too! ππ
Try to make it easier on your fellow devs and increase your teams overall code review quality by following these tips:
β super specific title
β full and helpful description (What? Why? How?)
β provide some context that this PR is within
β lowest number of code lines changes as possible; consider breaking up big PRs into smaller ones
β if itβs not beneficial to break down the PR, provide more description about the changes to break it up in that way
β Single responsibility: a PR should tackle one problem or insert one feature; donβt couple different units of work together
βοΈ Be honest; have you ever sped through a code review / pull request approval?
What tips do you have to help with this?
